Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#23627 improved getCustomerName method for Order #24746

Merged
merged 4 commits into from
Oct 15, 2019
Merged

#23627 improved getCustomerName method for Order #24746

merged 4 commits into from
Oct 15, 2019

Conversation

sergiy-v
Copy link
Contributor

Description (*)

Improved getCustomerName method for Order.

Fixed Issues (if relevant)

#23627

Manual testing scenarios (*)

  • Register a new customer with prefix, first name, middle name, last name, and suffix.
  • Place an order with the customer, check the customer name for the order confirmation email and customer details on order page, the prefix, middle name and suffix should be visible.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@sergiy-v sergiy-v requested a review from YevSent as a code owner September 27, 2019 11:04
@m2-assistant
Copy link

m2-assistant bot commented Sep 27, 2019

Hi @sergiy-v. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Component: Sales Release Line: 2.3 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Sep 27, 2019
@dmytro-ch dmytro-ch self-assigned this Sep 27, 2019
@dmytro-ch dmytro-ch self-requested a review September 27, 2019 11:16
dmytro-ch
dmytro-ch requested changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sergiy-v, thank you for your contribution! :)
Could you please fix Semantic Version Checker and Static Test failures?

@sergiy-v sergiy-v requested a review from dmytro-ch October 8, 2019 06:52
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6039 has been created to process this Pull Request
✳️ @dmytro-ch, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@dmytro-ch dmytro-ch added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Oct 8, 2019
@engcom-Bravo engcom-Bravo self-assigned this Oct 9, 2019
@engcom-Golf engcom-Golf self-assigned this Oct 10, 2019
@engcom-Bravo
Copy link
Contributor

✔️ QA passed

@VladimirZaets VladimirZaets removed the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Oct 14, 2019
@VladimirZaets VladimirZaets added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Oct 14, 2019
magento-engcom-team pushed a commit that referenced this pull request Oct 15, 2019
@VladimirZaets
ENGCOM-6039: #23627 improved getCustomerName method for Order #24746
1cdb6b4
@magento-engcom-team magento-engcom-team merged commit d4db3b3 into magento:2.3-develop Oct 15, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 15, 2019

Hi @sergiy-v, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Oct 15, 2019
@Bartlomiejsz Bartlomiejsz mentioned this pull request Oct 25, 2019
Closed
@sergiy-v sergiy-v deleted the 23627-order-get-customer-name-improvements branch February 28, 2020 06:28
@plastikschnitzer
Copy link

Is this fixed in Magento 2.3.5-p1? For me its not working there, middle name is showing up in the customer administration only, not in the order overview, order detail page or the transaction email.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch dmytro-ch approved these changes

@YevSent YevSent Awaiting requested review from YevSent

Assignees

@VladimirZaets VladimirZaets

@dmytro-ch dmytro-ch

@engcom-Bravo engcom-Bravo

@engcom-Golf engcom-Golf

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: Sales Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.4
Development

Successfully merging this pull request may close these issues.
8 participants
@sergiy-v @magento-engcom-team @engcom-Bravo @plastikschnitzer @dmytro-ch @VladimirZaets @engcom-Golf @Nazar65